From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 26 Aug 2026 22:17:37 +0000 (+0200)
Subject: dbusServices/screencast: Add more debug logging
X-Git-Tag: archive/raspbian/50.5-1+rpi1^2~6^2^2~19
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=6f0c80b62e578b650b2e70f5e43cef7714f1d15f;p=gnome-shell.git

dbusServices/screencast: Add more debug logging

Commit 8286ec5bb176c added some debug logging, but we still only log
a message when the pipeline creation fails directly. Add more logging
so that we always indicate why we are moving to the next pipeline
config.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4361>
(cherry picked from commit 5e9de9693593a7cbf2710562024531c16b62d8af)
---

diff --git a/js/dbusServices/screencast/screencastService.js b/js/dbusServices/screencast/screencastService.js
index bd2381a8f..e3b745bd2 100644
--- a/js/dbusServices/screencast/screencastService.js
+++ b/js/dbusServices/screencast/screencastService.js
@@ -331,6 +331,8 @@ class Recorder extends Signals.EventEmitter {
             retval === Gst.StateChangeReturn.ASYNC) {
             // We'll wait for the state change message to PLAYING on the bus
         } else {
+            const changeString = Gst.StateChangeReturn.get_name(retval);
+            console.debug(`Setting PLAYING state on pipeline returned ${changeString}`);
             this._tryNextPipeline();
         }
     }
@@ -423,6 +425,7 @@ class Recorder extends Signals.EventEmitter {
 
             case PipelineState.STARTING:
                 // This is something we can handle, try to switch to the next pipeline
+                console.debug('Received EOS message while trying to start pipeline');
                 this._tryNextPipeline();
                 break;
 
@@ -452,7 +455,9 @@ class Recorder extends Signals.EventEmitter {
 
             break;
 
-        case Gst.MessageType.ERROR:
+        case Gst.MessageType.ERROR: {
+            const [error] = message.parse_error();
+
             switch (this._pipelineState) {
             case PipelineState.INIT:
             case PipelineState.STOPPED:
@@ -462,13 +467,12 @@ class Recorder extends Signals.EventEmitter {
 
             case PipelineState.STARTING:
                 // This is something we can handle, try to switch to the next pipeline
+                console.debug(`Received ERROR message while trying to start pipeline: ${error.message}`);
                 this._tryNextPipeline();
                 break;
 
             case PipelineState.PLAYING:
             case PipelineState.FLUSHING: {
-                const [error] = message.parse_error();
-
                 if (error.matches(Gst.ResourceError, Gst.ResourceError.NO_SPACE_LEFT)) {
                     this._handleFatalPipelineError('Out of disk space',
                         ScreencastErrors, ScreencastError.OUT_OF_DISK_SPACE);
@@ -486,6 +490,7 @@ class Recorder extends Signals.EventEmitter {
             }
 
             break;
+        }
 
         default:
             break;